Merged
Conversation
Make assert_method_ref_receiver! fail loudly when a method reference is missing a receiver or when multiple references share the same name, so receiver tests can't silently validate the wrong match
alexcrocha
changed the title
vinistock
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on post-merge feedback from #662
assert_method_ref_receiver!now fails with a descriptive panic when a matched method reference has no receiver, and it requires exactly one method reference for the asserted name so tests cannot silently validate the wrong match. The macro documentation was also updated to reflect that uniqueness requirement.