Preserve unresolved items across resolve() calls#711
Merged
Conversation
vinistock
approved these changes
Apr 1, 2026
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
The solution looks good, just some code comments
st0012
force-pushed
the
fix-push-back-unresolved
branch
3 times, most recently
from
1dd659a to
638a24f
Compare
During incremental invalidation, references from surviving files may be consumed by delete-phase resolution where their target doesn't exist yet. Without pushing them back to pending_work, they're dropped permanently and never retried after the re-add phase recreates the target.
st0012
force-pushed
the
fix-push-back-unresolved
branch
from
638a24f to
851992b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found by the incremental consistency testing tool.
unit_queuelives on the Resolver (ephemeral), whilepending_worklives on Graph (persists acrossresolve()calls). With incremental invalidation, items can be temporarily unresolvable — e.g. a reference from a surviving file whose target was just deleted but will be re-added.unit_queueitems back topending_workviaGraph#extend_workat the end ofresolve()so they're retried on the next call.