Merged
Conversation
- cibuildgem supports building binary by any runners supported on GitHub. I originally didn't include this platform as I wasnt sure whether users would want a precompiled binary for linux aarch64. A user asked for it so let's add it to the matrix #714 I tested and it compiles correctly https://github.com/Shopify/rubydex/actions/runs/23947658226/job/69847719701 Though it compiles correctly since the latest release of ruby-rbs 0.3.0 thanks to thix fix ruby/rbs#2914
Contributor
|
The change itself looks good to me! However, I noticed that the build fails because ruby-rbs 0.3 contains breaking changes. (https://github.com/Shopify/rubydex/actions/runs/23947658226/job/69847719701) I think we should wait for #724 before merging this PR. |
vinistock
approved these changes
Apr 6, 2026
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
Yeah, let's merge Soutaro's fix first and then we're good to ship this
Contributor
|
I merged the RBS bump PR. So, it's ready to ship this PR! 🎉 |
Member
Author
|
Thanks @soutaro ! |
|
Can we cut a release with this change? We're using devcontainers on macOS, which requires the ARM64 Linux version of this gem. |
MikeMcQuaid
added a commit
to Homebrew/brew
that referenced
this pull request
Apr 10, 2026
We can remove < 0.19.0 when Shopify/rubydex#725 is in a release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precompile binary for linux aarch64
cibuildgem supports building binary for any platforms supported by github runners. I originally didn't include this platform as I wasnt sure whether users would want a precompiled binary for linux aarch64.
A user asked for it so let's add it to the matrix no aarch64 native gem for linux? #714
I tested and it compiles correctly https://github.com/Shopify/rubydex/actions/runs/23947658226/job/69847719701 Though it compiles correctly since the latest release of ruby-rbs 0.3.0 thanks to thix fix Use cast for converting source start pointer to c_char ruby/rbs#2914