Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7b3afb2 to
b6d4a2f
Compare
This was referenced Apr 16, 2026
b6d4a2f to
e42b1ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We were crashing when invoking
resolve_constantwith an empty constant name or an incomplete name likeFoo::. This PR ensures that we don't crash.I considered raising an error instead of returning
nil, but I talked myself out of doing so because then we'd essentially set the expectation that the API validates the fully qualified name. For example,""would raise, but without extra changes#@@<Foo>would be accepted. Instead of trying to validate every possible input, I just went withnil.