Group resolution tests into submodules#756
Open
alexcrocha wants to merge 19 commits intomainfrom
Open
Conversation
c9042e2 to
cf66a55
Compare
vinistock
approved these changes
Apr 27, 2026
Member
vinistock
left a comment
There was a problem hiding this comment.
IMO, I think the modules are bit too granular. For example, I would have a single ancestors module for everything related to ancestor chains rather than include, prepend... Especially because some of the scenarios mix things, so where would those go?
That said, we can always adjust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part of #649
By grouping the tests into semantically coherent submodules, we get collapsible navigation in editors and a layout that shows the resolver's surface area: constant lookup, ancestors/MRO, method dispatch, state & storage, dynamic/meta, and RBS. No test bodies change, each commit is a pure relocation.
Final layout:
Constant Lookup:
mod constant_resolution_tests;
mod constant_alias_tests;
Ancestors & Method Resolution Order:
mod superclass_tests;
mod include_tests;
mod prepend_tests;
mod mixin_dedup_tests;
mod object_ancestors_tests;
mod singleton_ancestors_tests;
Method Dispatch:
mod method_tests;
mod method_alias_tests;
State & Storage:
mod variable_tests;
mod declaration_creation_tests;
mod singleton_class_tests;
mod fqn_and_naming_tests;
mod todo_tests;
Dynamic / Meta:
mod dynamic_namespace_tests;
mod promotability_tests;
RBS:
mod rbs_tests;