Skip to content

Remove redundant semian naming from error messages #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nirmitparikh8 merged 1 commit into from
Sep 18, 2025
Merged

Remove redundant semian naming from error messages #751

nirmitparikh8 merged 1 commit into from
Sep 18, 2025

Conversation

@nirmitparikh8
Copy link
Contributor

@nirmitparikh8 nirmitparikh8 commented Sep 18, 2025

  • Removed semian resource name from ResourceBusyError and OpenCircuitError messages since it was redundant. Both of these errors are an instance of SemianError, and this object takes semian identifier and message and modifies the message to contain semian resource name.

@nirmitparikh8 nirmitparikh8 merged commit 1d254ee into main Sep 18, 2025
32 checks passed
@nirmitparikh8 nirmitparikh8 deleted the nirmitparikh/remove_redundant_logging branch September 18, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbdulRahmanAlHamali AbdulRahmanAlHamali AbdulRahmanAlHamali approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nirmitparikh8 @AbdulRahmanAlHamali