Skip to content

Remove unnecessary comments and fix smoother initalization#897

Merged
kris-gaudel merged 3 commits intopid-take-2from
kris-gaudel/set-initial-er
Nov 28, 2025
Merged

Remove unnecessary comments and fix smoother initalization#897
kris-gaudel merged 3 commits intopid-take-2from
kris-gaudel/set-initial-er

Conversation

@kris-gaudel
Copy link
Contributor

@kris-gaudel kris-gaudel commented Nov 27, 2025

This PR addresses the following issues:

  • There are a lot of variables left over from previous work (e.g., pre-filling with 15min of observations)
  • Variables that are just not used at all
  • Comments that are overly verbose and unnecessary
  • Limits parameter (e.g., parameters for smoother) setting to semian.rb

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely clear on why the graphs look different if this PR didn't change anything substantial? Or are we not tracking these too closely.

Copy link
Contributor

@adriangudas adriangudas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just left a few comments.

@kris-gaudel kris-gaudel merged commit facd604 into pid-take-2 Nov 28, 2025
32 checks passed
@kris-gaudel kris-gaudel deleted the kris-gaudel/set-initial-er branch November 28, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants