Fix commit status #1424
Merged
Fix commit status #1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
timothysmith0609
approved these changes
Sep 25, 2025
Comment on lines
+7
to
+11
| <% if commit.status.group? %> | ||
| <%= render 'shipit/statuses/group', group: commit.status %> | ||
| <% else %> | ||
| <%= render 'shipit/statuses/status', status: commit.status %> | ||
| <% end %> |
Contributor
There was a problem hiding this comment.
Not sure if we still need to_partial_path on Shipit::Status::Group|Missing|Unknown since we are explicitly calling out the partials now? (Not blocking)
Contributor
Author
There was a problem hiding this comment.
I may opt to follow up with a change to address this.
timothysmith0609
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1414 introduced changes to be explicit about the partial to render. However,
commit.statuscan also be a group, which in those instances would render the group partial. In the current state, we cannot view a set of build status's when hovering. This fix hopes to correct this.🎩 screenshots