Improve code and tests for the newest version of php-jwt#186
Improve code and tests for the newest version of php-jwt#186paulomarg merged 7 commits intoShopify:mainfrom
Conversation
|
+1 to this. |
|
+1 to this vulnerability fix |
|
+1 is this repository maintained anymore? 4 months nobody here to click accept... |
|
Rebased with main, made additional tests fixes, CLA signed. Waiting for an approval 🤷♂️ |
|
+99999999999999 |
|
+1, please can this be merged! |
|
The code is not reviewed by learn-libs-superteam. Could we add paulomarg or teddyhwang as reviewers ? |
I cannot add them because learn-libs-superteam is the the code owner and this can be the only reviewer :( |
Hi @paulomarg and @teddyhwang, |
paulomarg
left a comment
There was a problem hiding this comment.
Hi folks, sorry for the delay. We appreciate the contribution!
|
@paulomarg can you please bump the version also? |
WHY are these changes introduced?
Because of the vulnerabilities in the older version of php-jwt
https://snyk.io/vuln/composer:firebase%2Fphp-jwt
WHAT is this pull request doing?
Type of change
Checklist