Conversation
paulomarg
force-pushed
the
allow_http_host
branch
from
a45745e to
026f00f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
In order to run the CLI command
dev --no-tunnel, we need to make the library and template capable of using the HTTP scheme.WHAT is this pull request doing?
Removing any assumptions we had of the scheme being
https://, and replacing it with aContext::$HOST_SCHEMEthat can be derived fromContext::$HOST_NAME, if passed. We still default to HTTPS so this change does not affect existing apps.Type of change
Checklist