Add requirement for PHP extensions to composer.json#236
Merged
Jan0707 merged 16 commits intoShopify:mainfrom Apr 28, 2023
Merged
Add requirement for PHP extensions to composer.json#236Jan0707 merged 16 commits intoShopify:mainfrom
Jan0707 merged 16 commits intoShopify:mainfrom
Conversation
mb_strlen() is used on line 188 of src/Clients/Http.php
ctype_digit() is used on line 113 of src/Utils.php
hash_equals() is used on line 78 of src/Utils.php hash_hmac() is used on line 76 of src/Utils.php and in src/Auth/OAuth.php (lines 269, 294)
This reverts commit f157732.
|
LGTM! I hope we can get this merged soon |
This adds support for PHP version 7.4, to match declaration in this project.
|
Still LGTM, hopefully we can get this merged soon @paulomarg 🚀 |
3 tasks
Contributor
|
Hi @fredden ! We have just recently added validation and normalization for composer.json to our workflow. Would you mind updating your PR to resolve the conflicts :) Looks good otherwise! |
Contributor
Author
|
@Jan0707 yes. I've resolved the merge conflicts introduced today twice now. Feel free to squash-merge this to keep the main branch clean, or I can rebase this onto the main branch if you'd prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
On line 188 of
src/Clients/Http.php, the functionmb_strlen()is used. After installing this library on a new server, I got an error from PHP saying:PHP Fatal error: Uncaught Error: Call to undefined function Shopify\Clients\mb_strlen() in .../vendor/shopify/shopify-api/src/Clients/Http.php:188shopify-api-php/src/Clients/Http.php
Line 188 in 432676a
WHAT is this pull request doing?
This pull request updates the list of requirements in
composer.jsonto include thembstringextension, which is required for this library to work properly.Update: while I was completing the 'checklist' in the GitHub pull request template, I added a test to catch this problem, and found some more extensions which are required and not listed.
Type of change
Checklist