changed value of sessionExpiration to 0 instead of null if session->g…#292
Closed
da-mask wants to merge 1 commit intoShopify:mainfrom
Closed
Conversation
…etExpires is false
Contributor
Author
|
This would close issue #291 |
Contributor
Author
|
"I have signed the CLA!" |
da-mask
deleted the
issue_where_embedded_app_is_trying_to_pass_null_to_expire_in_setcookie
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…etExpires is false
WHY are these changes introduced?
Fixes #291
WHAT is this pull request doing?
Type of change
Checklist