Skip to content

getJsonResponseBodyName is now an array#297

Merged
mllemango merged 2 commits intomainfrom
melaniew/custom-json-body-names-to-array
Sep 5, 2023
Merged

getJsonResponseBodyName is now an array#297
mllemango merged 2 commits intomainfrom
melaniew/custom-json-body-names-to-array

Conversation

@mllemango
Copy link
Copy Markdown
Contributor

@mllemango mllemango commented Sep 5, 2023

WHY are these changes introduced?

Closes #258
Also FulfillmentRequest wouldn't have returned an object upon save, now it will

WHAT is this pull request doing?

We are making getJsonResponseBodyName an array to accept multiple possibilities that the API returns. This will let us resolve a few issues that we've faced before with our rest client

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@mllemango mllemango requested a review from paulomarg September 5, 2023 15:40
Copy link
Copy Markdown
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@mllemango mllemango merged commit f5f4fe4 into main Sep 5, 2023
@mllemango mllemango deleted the melaniew/custom-json-body-names-to-array branch September 5, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when doing save($updateObject = true) on CustomerAddress object (and maybe others) due to getJsonBodyName returning wrong array key

2 participants