Update rest.md arguments table to be current.#90
Merged
Conversation
thecodepixi
force-pushed
the
thecodepixi/correct_rest_args_table
branch
from
97e8408 to
27302e2
Compare
paulomarg
approved these changes
Aug 9, 2021
Contributor
paulomarg
left a comment
paulomarg
left a comment
There was a problem hiding this comment.
LGTM, with 2 nits:
- Double checking that
triescomes beforequery - Is the Graphql
querycall correct?
Contributor
Author
I'm just looking at REST for now. I'll see what's inconsistent with GraphQL when I get there and make a separate PR if that works for you? |
thecodepixi
force-pushed
the
thecodepixi/correct_rest_args_table
branch
from
27302e2 to
ca84807
Compare
thecodepixi
force-pushed
the
thecodepixi/correct_rest_args_table
branch
from
ca84807 to
e623c95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The arguments table for the REST client was out of date.
WHAT is this pull request doing?
This updates the argument order in the table as well as which arguments are required and what their
Types are.Type of change
Checklist