Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Fix null value in monorail payload #1246

Merged
mllemango merged 1 commit intomasterfrom
melanie/fix-null-entry-monorail
May 20, 2021
Merged

Fix null value in monorail payload #1246
mllemango merged 1 commit intomasterfrom
melanie/fix-null-entry-monorail

Conversation

@mllemango
Copy link

@mllemango mllemango commented May 20, 2021

WHY are these changes introduced?

TIL: false || nil returns nil

WHAT is this pull request doing?

Forcing the expression to return false instead of nil because monorail requests would fail silently due to a schema validation error where is_employee cannot be null

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).
  • I've left the version number as is (we'll handle incrmenting this when releasing).

@mllemango mllemango requested a review from mkevinosullivan May 20, 2021 14:07
@mllemango mllemango merged commit 8eebb5d into master May 20, 2021
@mllemango mllemango deleted the melanie/fix-null-entry-monorail branch May 20, 2021 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants