Update globals for usage with plugin v2#34
Merged
Merged
Conversation
saga-dasgupta
approved these changes
Apr 25, 2025
Contributor
saga-dasgupta
left a comment
saga-dasgupta
left a comment
There was a problem hiding this comment.
Makes sense to me.
| @@ -1,23 +1,28 @@ | |||
| export type ShopifyFunction<Input extends {}, Output extends {}> = ( | |||
| export type userFunction<Input extends {}, Output extends {}> = ( | |||
Contributor
There was a problem hiding this comment.
Any particular reason why the name of this type was updated?
Contributor
Author
There was a problem hiding this comment.
I think since it was ShopifyFunction, it was colliding with the same-named interface or global.
shopify-function-javascript/run.ts
Lines 5 to 12 in 385a0a5
Contributor
There was a problem hiding this comment.
Right, I was mostly asking because types are usually capitalized, UserFunction. Mind capitalizing this type?
saulecabrera
approved these changes
Apr 25, 2025
lopert
force-pushed
the
lopert.use-javy-v2
branch
from
b9c503a to
1f06878
Compare
lopert
changed the title
Contributor
Author
|
Keeping the version bump as a major one since that affects our build-time check over in the CLI. Keeping it as major will allow us to use that check to make sure things stay aligned. |
Contributor
|
/snapit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/shop/issues-shopifyvm/issues/29
majorat least minor to avoid having older/existing CLI client/extensions pulling this in (the dep is ~tilde) and attempting to use it with plugin v1Updates the globals to use
ShopifyFunctioninstead ofJavy.JSON.