Setup the package for multiple exports #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to leverage Javy's new multi-export feature. This commit helps by: 1. Extracting the logic for running a function (stream & JSON handling) to a `run` function that can be used without `index.ts`. 2. Making `javy` a peerDependency so that it's still accessible for `run`, (without using any file here as esbuild's entrypoint).
jbourassa
commented
Jul 14, 2023
Comment on lines
-6
to
-8
| export type ShopifyFunction<Input extends {}, Output extends {}> = ( | ||
| input: Input | ||
| ) => Output; |
Contributor
Author
There was a problem hiding this comment.
Do we expect anyone to be using this exported type? If so, I can re-export it.
jeffcharles
approved these changes
Jul 17, 2023
Contributor
|
FYI deploy failed because I accidentally created the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to leverage Javy's new multi-export feature. This commit helps by:
runfunction that can be used withoutindex.ts.javya peerDependency so that it's still accessible forrun, (without using any file here as esbuild's entrypoint).Part of https://github.com/Shopify/script-service/issues/7050
#gsd:34464