Add default value to Configuration.scope parameter to make it optional#1913
Merged
Add default value to Configuration.scope parameter to make it optional#1913
Conversation
973ac99 to
79519b6
Compare
79519b6 to
b21a65f
Compare
lizkenyon
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to
What this PR does
Fixes:
ShopifyApp.configureif we already declare them on the.tomlconfig file? #1912Background
The
scopeparameter was required as a part of the legacy OAuth flow (Authorization code grant).ShopifyAPI::Contextsetup process, but has been changed to be optional from this PRShopifyApp.configurationdoes not have explicit expectation forconfig.scopeto be configured, but it will encounter an error during OAuth from ShopStrategySolution
Making
ShopifyApp.configuration.scopeto have a default value[]so it can be omitted during setup.How has this been tested?
config.scopesetup in theShopifyApp.configuremethodconfig.scopevalues are ignored during installationconfig.scopevalues are used during installationChecklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary