Fix empty string fallback for comment_package_manager#55
Merged
gonzaloriestra merged 1 commit intoregistry-and-package-managerfrom Apr 16, 2026
Merged
Conversation
When comment_package_manager input is not set, core.getInput() returns an empty string. Using nullish coalescing (??) fails to fall back to the auto-detected packageManager because empty string is not nullish. This causes the install command to render as 'i -g' instead of 'npm i -g'. Switch to logical OR (||) so empty string correctly falls through to the detected package manager.
shopify-river
bot
force-pushed
the
fix-empty-package-manager-fallback
branch
from
828ddad to
8051ff5
Compare
alfonso-noriega
approved these changes
Apr 16, 2026
alfonso-noriega
requested review from
alfonso-noriega
and removed request for
alfonso-noriega
gonzaloriestra
approved these changes
Apr 16, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
comment_package_managerinput is not set,core.getInput()returns an empty string. Using nullish coalescing (??) fails to fall back to the auto-detectedpackageManagerbecause empty string is not nullish. This causes the install command to render asi -ginstead ofnpm i -g.Switch to logical OR (||) so empty string correctly falls through to the detected package manager.