Conversation
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
commented
Oct 15, 2021
| def colorize(string, *color) | ||
| return string unless color? | ||
| string.colorize(color) | ||
| T.unsafe(self).set_color(string, *color) |
Contributor
Author
There was a problem hiding this comment.
Using unsafe because of the splat 😢
Morriar
commented
Oct 15, 2021
| sig { params(string: String, color: Spoom::Color).returns(String) } | ||
| def colorize(string, *color) | ||
| return string unless @colors | ||
| T.unsafe(self).set_color(string, *color) |
Contributor
Author
There was a problem hiding this comment.
Using unsafe because of the splat 😢
Morriar
commented
Oct 15, 2021
| # frozen_string_literal: true | ||
|
|
||
| module Spoom | ||
| class Color < T::Enum |
Contributor
Author
There was a problem hiding this comment.
Thinking about it, maybe I should nest this under CLI
Contributor
Author
There was a problem hiding this comment.
I think I'll keep the diff in this PR to a minimum and do some cleaning in the helpers in a subsequent one.
vinistock
approved these changes
Oct 15, 2021
rafaelfranca
approved these changes
Oct 15, 2021
paracycle
approved these changes
Oct 15, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement our own coloration helper for shell display that is type-friendly.
Fixes #101.