Add Ruby 3.1 to CI#116
Merged
Morriar merged 3 commits intoShopify:mainfrom Jan 31, 2022
petergoldstein:feature/add_ruby_3_1_to_ci
Merged
Add Ruby 3.1 to CI#116Morriar merged 3 commits intoShopify:mainfrom petergoldstein:feature/add_ruby_3_1_to_ci
Morriar merged 3 commits intoShopify:mainfrom
petergoldstein:feature/add_ruby_3_1_to_ci
Conversation
Morriar
reviewed
Jan 27, 2022
.github/workflows/ruby.yml
Outdated
| experimental: true | ||
|
|
||
| env: | ||
| RUBYOPT: "--disable-error_highlight" |
Contributor
Author
There was a problem hiding this comment.
I added this because I misidentified the DidYouMean failures in the Ruby 3.1 run as being a result of the error highlighting which is on by default in Ruby 3.1. It's not - it looks like some other issue, either in the Ruby itself or its supporting infrastructure. Removed.
Contributor
|
Indeed there is something flaky with the |
Morriar
approved these changes
Jan 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Ruby 3.1 to the CI matrix and shifts Ruby 3.0 out of experimental.
It also addresses some syntax issues in the CI config:
I'm seeing flaky failures on one individual spec, shifting between Ruby versions with different runs.