Skip to content

Fix position of expected values in assert_equal#121

Merged
Morriar merged 1 commit intomainfrom
at-fix-exp-order
Mar 9, 2022
Merged

Fix position of expected values in assert_equal#121
Morriar merged 1 commit intomainfrom
at-fix-exp-order

Conversation

@Morriar
Copy link
Contributor

@Morriar Morriar commented Mar 9, 2022

As noted by @KaanOzkan, the expected value should come first.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added the chore Chore task label Mar 9, 2022
@Morriar Morriar requested a review from a team March 9, 2022 19:00
@Morriar Morriar self-assigned this Mar 9, 2022
Copy link
Contributor

@RyanBrushett RyanBrushett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@Morriar Morriar merged commit a968972 into main Mar 9, 2022
@Morriar Morriar deleted the at-fix-exp-order branch March 9, 2022 19:40
@shopify-shipit shopify-shipit bot temporarily deployed to production March 22, 2022 15:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chore task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants