Fix flaky test_run_srb_from_bundler_not_found test#122
Merged
Conversation
This was actually order dependent. If this test is executed first and the gem `sorbet` is not installed on the system Bundler won't know about it and simply exit with a 127 error code. Whereas if this test is executed _after_ one installing `sorbet`, Bundler will see the `srb` executable in the GEM_PATH and raise a different error (explaining that the executable is not in the bundle) and return 1 instead. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com> Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
vinistock
approved these changes
Mar 9, 2022
KaanOzkan
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117.
This was actually order dependent.
If this test is executed first and the gem
sorbetis not installedon the system Bundler won't know about it and simply exit with a 127
error code.
Whereas if this test is executed after one installing
sorbet, Bundlerwill see the
srbexecutable in the GEM_PATH and raise a different error(explaining that the executable is not in the bundle) and return 1 instead.