Conversation
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
commented
Feb 4, 2021
| desc "snapshot", "Run srb tc and display metrics" | ||
| option :save, type: :string, lazy_default: DATA_DIR, desc: "Save snapshot data as json" | ||
| option :rbi, type: :boolean, default: true, desc: "Exclude RBI files from metrics" | ||
| option :rbi, type: :boolean, default: true, desc: "Include RBI files in metrics" |
Contributor
Author
There was a problem hiding this comment.
This is the other way around. It comes from a refactor and I forgot to change the description.
Morriar
commented
Feb 4, 2021
| pointer-events: none; | ||
| } | ||
|
|
||
| .area { |
Contributor
Author
There was a problem hiding this comment.
Some cleaning in the CSS
Morriar
commented
Feb 4, 2021
| JS | ||
| end | ||
| end | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I really need to find a better way to design/refactor/reuse those components...
mutecipher
approved these changes
Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Count & store RBI count in snapshot so we can keep an eye on the amount of files vs. RBI files we have in a project: