Add option to count errors if files were bumped to true#76
Merged
Conversation
Morriar
reviewed
Mar 15, 2021
Morriar
reviewed
Mar 15, 2021
4d0151d to
d2c50ec
Compare
Morriar
reviewed
Mar 16, 2021
d2c50ec to
ab1dbb2
Compare
ab1dbb2 to
c870da0
Compare
Morriar
approved these changes
Mar 16, 2021
Contributor
Morriar
left a comment
There was a problem hiding this comment.
Thanks for indulging me! 🙏
RyanBrushett
approved these changes
Mar 18, 2021
Contributor
|
@vinistock I just realized we should also add an entry in the README about this option: https://github.com/Shopify/spoom/blob/master/README.md#change-the-sigil-used-in-files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--count-errorsoption to bump, which is similar to a dry run, but prints the number of total errors if all files were bumped to true. No changes are made to the files.This is useful for measuring typing progress in big code bases where addressing a specific signature or error doesn't unlock the file being
typed: true, but already reduces the remaining errors to fix.This is how the output looks. (

bspoomis just an alias forbin/spoom).