Skip to content

Add option to count errors if files were bumped to true#76

Merged
vinistock merged 1 commit intomasterfrom
add_command_to_count_errors
Mar 18, 2021
Merged

Add option to count errors if files were bumped to true#76
vinistock merged 1 commit intomasterfrom
add_command_to_count_errors

Conversation

@vinistock
Copy link
Member

@vinistock vinistock commented Mar 15, 2021

Add --count-errors option to bump, which is similar to a dry run, but prints the number of total errors if all files were bumped to true. No changes are made to the files.

This is useful for measuring typing progress in big code bases where addressing a specific signature or error doesn't unlock the file being typed: true, but already reduces the remaining errors to fix.

This is how the output looks. (bspoom is just an alias for bin/spoom).
Screen Shot 2021-03-15 at 3 36 09 PM

@vinistock vinistock requested a review from a team March 15, 2021 19:59
@vinistock vinistock force-pushed the add_command_to_count_errors branch from 4d0151d to d2c50ec Compare March 16, 2021 13:19
@vinistock vinistock force-pushed the add_command_to_count_errors branch from d2c50ec to ab1dbb2 Compare March 16, 2021 14:17
@vinistock vinistock force-pushed the add_command_to_count_errors branch from ab1dbb2 to c870da0 Compare March 16, 2021 14:25
Copy link
Contributor

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for indulging me! 🙏

@vinistock vinistock merged commit 2957401 into master Mar 18, 2021
@vinistock vinistock deleted the add_command_to_count_errors branch March 18, 2021 13:45
@Morriar
Copy link
Contributor

Morriar commented Mar 18, 2021

@vinistock I just realized we should also add an entry in the README about this option: https://github.com/Shopify/spoom/blob/master/README.md#change-the-sigil-used-in-files

@vinistock vinistock temporarily deployed to production March 19, 2021 18:53 Inactive
@Morriar Morriar added the feature New feature label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants