Merged
Conversation
vinistock
force-pushed
the
use_new_no_errors_option
branch
from
c6a8019 to
51422cb
Compare
vinistock
commented
Mar 16, 2021
| o.close | ||
| err = e.read.to_s | ||
| e.close | ||
| i.close |
Member
Author
There was a problem hiding this comment.
This was breaking locally with an error related to having too many files open from Open3.
vinistock
commented
Mar 16, 2021
| Error: Sorbet returned typechecking errors for `/errors.rb` | ||
| 8:0-8:11: Not enough arguments provided for method `Foo#foo`. Expected: `1`, got: `0` (7004) | ||
| 4:2-5:5: Returning value that does not conform to method result type (7005) | ||
| 4:2-5:5: Expected `String` but found `NilClass` for method result type (7005) |
Member
Author
There was a problem hiding this comment.
This changed after the Sorbet upgrade.
Morriar
approved these changes
Mar 16, 2021
| o.close | ||
| err = e.read.to_s | ||
| e.close | ||
| i.close |
Contributor
|
Looks like the Sorbet bump also created errors around blocks: https://github.com/Shopify/spoom/pull/77/checks?check_run_id=2125606434 we might have to update those definitions upstream :/ |
RyanBrushett
approved these changes
Mar 16, 2021
Contributor
RyanBrushett
left a comment
RyanBrushett
left a comment
There was a problem hiding this comment.
Your CI failures are related to upstream RBI files defining a method that is missing an explicit block param. Happy to 🍐 to fix those if you're interested!
Member
Author
|
Fixed the types for |
vinistock
force-pushed
the
use_new_no_errors_option
branch
from
51422cb to
50dfb89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new option introduced in sorbet/sorbet#4078 for Spoom bump.
I locked the version of Sorbet to be greater or equal to the one where the new option is introduced.