Skip to content

Do not crash when requesting sigil from a directory instead of a file #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Morriar merged 1 commit into from
Jun 8, 2021
Merged

Do not crash when requesting sigil from a directory instead of a file #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/spoom/sorbet/sigils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def self.update_sigil(content, new_strictness)
# * returns nil if no sigil
sig { params(path: T.any(String, Pathname)).returns(T.nilable(String)) }
def self.file_strictness(path)
return nil unless File.exist?(path)
return nil unless File.file?(path)
content = File.read(path, encoding: Encoding::ASCII_8BIT)
strictness_in_content(content)
end
Expand Down
5 changes: 5 additions & 0 deletions test/spoom/sorbet/sigils_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,11 @@ def test_file_strictness_returns_nil_if_file_not_found
assert_nil(strictness)
end

def test_file_strictness_returns_nil_if_file_is_dir
strictness = Sigils.file_strictness("/")
assert_nil(strictness)
end

def test_file_strictness_with_valid_sigil
project = spoom_project("test_sigils")
project.write("file.rb", "# typed: true")
Expand Down