Conversation
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
KaanOzkan
approved these changes
Jun 3, 2021
Contributor
KaanOzkan
left a comment
There was a problem hiding this comment.
What exactly does --no-stdlib do inside Sorbet? Does it not include RBIs on objects from Ruby standard library?
Contributor
Author
By passing This means that to compute the coverage timeline for the first commits in Core, we need to pass this option of Sorbet tries to load the stdlib RBIs over the payload ones. |
vinistock
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When computing typing coverage for a project which use
--no-stdlibwe should pass back this option. Without it, Sorbet will hang or return a bazillion errors.This PR makes the
Configparser recognize--no-stdlibin the config file and generate it when we ask for the options string.