Fix missing indentation for @overridable annotation in RBS translation#909
Merged
Fix missing indentation for @overridable annotation in RBS translation#909
Conversation
vinistock
approved these changes
Apr 28, 2026
The `@overridable` annotation insert was missing the `#{indent}` suffix
after the newline, causing the subsequent `#:` signature line to start
at column 0 instead of matching the method's indentation level. All
other annotations (`@without_runtime`, `@final`, `@abstract`, `@override`)
already included the indent.
Morriar
force-pushed
the
at/fix-overridable-indentation
branch
from
e83dd54 to
1f0feaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@overridableannotation insert was missing the#{indent}suffix after the newline, causing the subsequent#:signature line to start at column 0 instead of matching the method's indentation level@without_runtime,@final,@abstract,@override) already included the indentoverridableinside a class to catch the indentation bugTest plan
test_translate_to_rbs_method_sigs_with_overridable_annotation_indentedwhich verifies correct indentation when translating an overridable sig inside a classcc. @jesse-shopify