Skip to content

checkout the original branch instead of commit when available#92

Merged
Morriar merged 1 commit intomasterfrom
checkout-branch
Jun 22, 2021
Merged

checkout the original branch instead of commit when available#92
Morriar merged 1 commit intomasterfrom
checkout-branch

Conversation

@ghost
Copy link

@ghost ghost commented Jun 15, 2021

This addresses the issue that spoom would checkout the original commit instead of the original branch when running the coverage command.

This is a draft PR as I have not figured out how to simulate being on a branch in a test yet, so do not have a test for the behaviour yet.

@ghost ghost force-pushed the checkout-branch branch 2 times, most recently from 898fad0 to 2d09bd7 Compare June 16, 2021 01:16
@ghost ghost marked this pull request as ready for review June 16, 2021 01:35
@ghost ghost requested review from a team and Morriar June 16, 2021 01:36
@ghost ghost force-pushed the checkout-branch branch from 2d09bd7 to f728b28 Compare June 16, 2021 14:27
Copy link
Contributor

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks! ❤️

@Morriar Morriar merged commit 50514e6 into master Jun 22, 2021
@Morriar Morriar deleted the checkout-branch branch June 22, 2021 14:15
@shopify-shipit shopify-shipit bot temporarily deployed to production July 28, 2021 15:30 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production December 8, 2021 21:43 Inactive
@Morriar Morriar added the enhancement New feature or request label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants