Skip to content

Ignore comments and blank lines in sorbet/config files (fixes issue #93). #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Morriar merged 1 commit into from
Jul 28, 2021
Merged

Ignore comments and blank lines in sorbet/config files (fixes issue #93). #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/spoom/sorbet/config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ def parse_string(sorbet_config)
state = :skip
when /^-.*=?/
next
when /^#/
next
when /^$/
next
else
case state
when :ignore
Expand Down
31 changes: 31 additions & 0 deletions test/spoom/sorbet/config_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,37 @@ def test_parses_a_config_string_with_mixed_options
assert_empty(config.allowed_extensions)
end

def test_parses_a_config_string_with_mixed_options_comments_and_empty_lines
config = Spoom::Sorbet::Config.parse_string(<<~CONFIG)
a
--other=b
# This is a comment.
--file
c

--d
e
--dir=f
-g
--dir

h
--file=i
--ignore
# Comment in between.
j
--ignore=k
l
m
-n
--o
p
CONFIG
assert_equal(['a', 'c', 'f', 'h', 'i', 'l', 'm'], config.paths)
assert_equal(['j', 'k'], config.ignore)
assert_empty(config.allowed_extensions)
end

def test_parses_a_real_config_string
config = Spoom::Sorbet::Config.parse_string(<<~CONFIG)
.
Expand Down