Use Prism.parse_success? to skip reifying the AST #2067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
approved these changes
Nov 4, 2024
paracycle
reviewed
Nov 4, 2024
| sig { params(name: String).returns(T::Boolean) } | ||
| def valid_method_name?(name) | ||
| Prism.parse("def self.#{name}(a); end").success? | ||
| Prism.parse_success?("def self.#{name}(a); end") |
Member
There was a problem hiding this comment.
This should be done for line 115 as well: https://github.com/Shopify/tapioca/pull/2067/files#diff-d83dd54865c126791df7c2e1c33243083422b0e90f937a4bdab3be90dca5f257R115
vinistock
approved these changes
Nov 4, 2024
KaanOzkan
force-pushed
the
ko/parse-success
branch
from
d150aee to
792a4f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Based on @kddnewton's suggestion in #2060 (comment) 🙇
Implementation
Tests
Existing