[Tapioca Addon] Handle missing gems gracefully in tapioca gem command

[alexcrocha]

Motivation

Currently, when a gem specified in the tapioca gem command isn't found by bundler, the process fails with a Thor::Error. This creates a poor user experience on the rare instances when the Tapioca LSP Addon runs the command with multiple gems where some might not be available.

Implementation

With this change, when the --lsp_addon flag is used, the command will now output a warning when a gem isn't found and continue processing other gems instead of crashing the process. This allows the Tapioca LSP Addon to handle missing gems gracefully while still generating RBIs for the available ones.

Without --lsp_addon, the command maintains its existing behaviour of failing with an error when a gem cannot be found.

[rzane]

I'm not a maintainer, but I want to call out that this change would allow (gem_names - @excluded) to change back to gem_names.

See: #2096

[andyw8]

This creates a poor user experience, especially when running the command with multiple gems where some might not be available.

Can you explain some more about this use case? If I entered an invalid gem name, I would expect tapioca to stop (and exit with a useful error).

[andyw8]

(and let's add a test if we choose to proceed)

[KaanOzkan]

Can you explain some more about this use case? If I entered an invalid gem name, I would expect tapioca to stop (and exit with a useful error).

LSP add-on will supply gem names very leniently and as a result can hit this exception often. We think it's cleaner to fix it here than rescue exceptions.

In your use case we'll still exit without doing much work

tapioca/lib/tapioca/commands/gem_generate.rb

Line 22 in 1705eb0

gem_queue.any?,

(and let's add a test if we choose to proceed)

Yes we need a CLI tests to accompany this change.

[andyw8]

Got it. Can we detect if running through the LSP or not, and respond accordingly?

[andyw8]

(nit) Since say doesn't return anything meaningful, I think we shouldn't pass is it to next.

Suggested change

	next say("Warning: Cannot find gem '#{gem_name}', skipping", :yellow) if @lsp_addon
	if @lsp_addon
	say("Warning: Cannot find gem '#{gem_name}', skipping", :yellow)
	next
	end

[KaanOzkan]

Another point: I think someone else brought this up before but if we're going to make this specific to lsp_addon I'd be okay with not outputting the warning log.

[alexcrocha]

That's fair. It does create a bit of noise that might not be very relevant.

I'll remove the warning log.