Generate Active Model attributes in an included GeneratedAttributeMethods module

[paracycle]

Motivation

Consumers that define Active Model classes which override any of the attribute models cannot override the signature of the generated attribute methods since we are making it look like the methods are defined on the model class, and not on an included module.

Implementation

Start generating all attribute methods on a GeneratedAttributeMethods module that gets included into the model class.

Tests

Update the existing tests to match

[bslobodin]

I'll try to find a bit of time to dig deeper, but a basic test locally ends up with rbis that have a few errors.

• https://github.com/Shopify/trust-battery/compare/bs/test-tapioca
• https://buildkite.com/shopify/trust-battery/builds/10842/steps/canvas?sid=01982e20-a65b-4771-a4e3-4aad33482a48#01982e20-a6dc-4275-9b05-17d8676e276e/156

I also noticed this during bin/tapioca gem, not sure if red herring or not,

Changed strictness of sorbet/rbi/gems/tapioca@0.17.7-8322b4a3836d2efbef293a9963e1cd5b8e2be8fb.rbi to typed: false (conflicting with DSL files)

[paracycle]

I'll try to find a bit of time to dig deeper, but a basic test locally ends up with rbis that have a few errors.

• https://github.com/Shopify/trust-battery/compare/bs/test-tapioca
• https://buildkite.com/shopify/trust-battery/builds/10842/steps/canvas?sid=01982e20-a65b-4771-a4e3-4aad33482a48#01982e20-a6dc-4275-9b05-17d8676e276e/156

I took a cursory look at the type checking failures and they all seem to be related to the fact that the signature of the attribute method on the class doesn't match the one coming from the method on the GeneratedAttributeMethods module.

For example:

class Foo
  extend T::Sig
  include ActiveModel::Attributes

  attribute :name, :string

  sig { returns(String) }
  def name = super
end

should fail, since the signature of super is returns(T.nilable(String)), which doesn't match the declared return type of Foo#name.

All in all, I think your errors are now expected and are better signals for you to either change the signature on the custom me|thod to match the attribute one or to do the code change needed to make it match (like super || "No Name", for example).