Fix RBS comment prefix in YardDoc listener #2364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
reviewed
Jul 24, 2025
| #: (String line) -> bool | ||
| def rbs_comment?(line) | ||
| line.strip.start_with?(": ", "| ") | ||
| line.start_with?(":", "|") |
Contributor
There was a problem hiding this comment.
Do we expect some RBS comments to not have the space?
Contributor
Author
There was a problem hiding this comment.
No, I removed it by accident, fixed.
Morriar
reviewed
Jul 24, 2025
| #: (String line) -> bool | ||
| def rbs_comment?(line) | ||
| line.strip.start_with?(": ", "| ") | ||
| line.start_with?(":", "|") |
Contributor
There was a problem hiding this comment.
Suggested change
| line.start_with?(":", "|") | |
| line.start_with?(": ", "| ") |
KaanOzkan
force-pushed
the
ko/yard-doc-rbs-2
branch
from
f7a67c2 to
0ca0ed5
Compare
KaanOzkan
force-pushed
the
ko/yard-doc-rbs-2
branch
from
0ca0ed5 to
6ebb0ba
Compare
paracycle
approved these changes
Jul 25, 2025
Morriar
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #2361
Implementation
Tests