Prevent gems from calling exit or abort during gem load
#2387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
approved these changes
Sep 12, 2025
paracycle
force-pushed
the
uk-abort-during-gem-load
branch
from
d2046cd to
8aa00da
Compare
Morriar
reviewed
Oct 2, 2025
| ) if @file_header | ||
|
|
||
| rbi.root = Runtime::Trackers::Autoload.with_disabled_exits do | ||
| rbi.root = Tapioca.with_disabled_exits do |
Contributor
There was a problem hiding this comment.
I think it could have stayed under Runtime with other runtime related helpers
Member
Author
There was a problem hiding this comment.
We can move both of the runtime helper methods under runtime, no problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have some internal gems that are meant to be used only during development. They have started enforcing that with a check at gem load time, and by calling
exitto abort the process. This breaks Tapioca gem loading unnecessarily.Implementation
We've already had the mechanism for running a block with disabled exits, so I just moved that to top level, and started using it around gem loading as well.
Tests
Added a test for the new expected behaviour.