Migrate Ruby LSP add-on to Rubydex#2620
Draft
vinistock wants to merge 3 commits into
Draft
Conversation
19 tasks
vinistock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate to the latest version of the Ruby LSP, Rubydex and the Rails add-on.
Note: it might be better to wait for shipping this PR once a stable Ruby LSP is out. CI is failing because parts of the matrix pick up the stable
v0.26series, which does not use Rubydex.Implementation
The migration itself is pretty straightforward. The only usage of indexing related features is to map which declarations got modified as part of a document update, which means traversing the Rubydex graph from the bottom up
document->definitions->declarations->fully_qualified_names.Tests
Existing tests cover it.