Avoid generating syntax errors for capitalized protobuf fields#878
Merged
Avoid generating syntax errors for capitalized protobuf fields#878
Conversation
vinistock
approved these changes
Mar 29, 2022
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
d8e286d to
f1cecaa
Compare
rafaelfranca
approved these changes
Mar 29, 2022
paracycle
pushed a commit
that referenced
this pull request
Apr 29, 2022
Avoid generating syntax errors for capitalized protobuf fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With Protobuf it seems possible to write fields with capitalized names:
In its current state, Tapioca will generate a syntactically incorrect RBI:
While we do want to generate constructors with named fields, we could fallback on taking a Hash if the name of one of the field is not suitable for a named parameter:
Tests
See automated tests.