Update color palette definition#1644
Merged
Merged
Conversation
NathanPJF
force-pushed
the
update-color-palette-definition
branch
3 times, most recently
from
fa0f319 to
f61732c
Compare
NathanPJF
force-pushed
the
update-color-palette-definition
branch
from
f61732c to
597edbb
Compare
aswamy
approved these changes
May 12, 2026
Contributor
aswamy
left a comment
aswamy
left a comment
There was a problem hiding this comment.
1 suggestion to make the error more human friendly when seen through an editor
Comment on lines
+1119
to
+1123
| "id": { | ||
| "type": "string", | ||
| "description": "The unique identifier for the setting, which is used to access the setting value.", | ||
| "markdownDescription": "The unique identifier for the setting, which is used to access the setting value.\n\n---\n\n[Shopify reference](https://shopify.dev/docs/themes/architecture/settings/input-settings#standard-attributes)" | ||
| } |
Contributor
There was a problem hiding this comment.
I noticed this is repeated a lot in the schema; not a problem in this PR since it looks like we did it before as well, but should clean it up in a follow-up PR.
| "type": "object", | ||
| "minProperties": 1, | ||
| "maxProperties": 20, | ||
| "propertyNames": { "pattern": "^[a-zA-Z]\\w*$" }, |
Contributor
There was a problem hiding this comment.
Suggested change
| "propertyNames": { "pattern": "^[a-zA-Z]\\w*$" }, | |
| "propertyNames": { | |
| "pattern": "^[a-zA-Z]\\w*$", | |
| "patternErrorMessage": "Color palette names must start with a letter and contain only letters, digits, and underscores." | |
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1565
Update definition for changes to
color_paletteinput. No longer inherit standard input definition; create a new bespoke definition.Color palette input only supports:
idtypedefaultAll of which is required, including a
defaultfield with initial color palettes.Updates test cases for
color_palettespecific considerations. e.g. a color palette name cannot have a-character in it or start with a number.