Remove 'CaptureOnContentForBlock' check #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswamy
approved these changes
Sep 12, 2025
Contributor
aswamy
left a comment
aswamy
left a comment
There was a problem hiding this comment.
Did we have the check for performance reasons? Or was it functionally not possible to do this before?
EvilGenius13
approved these changes
Sep 12, 2025
karreiro
commented
Sep 16, 2025
Contributor
Author
@aswamy It wasn’t for performance reasons. In some situations, this approach can lead to a less-than-ideal editing experience within the theme editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
This PR removes the
CaptureOnContentForBlockcheck from the codebase. As theme development standards have evolved, this check is now fully deactivated on all major themes.With the growing adoption of blocks, using this approach has become a standard way to encourage reusability and prevent duplicate markup.
What's next? Any followup issues?