Fix false reporting of UndefinedObject within visible_if #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
commented
Sep 24, 2025
|
|
||
| it('should not report unused assigns for things used in a raw-like tag', async () => { | ||
| const tags = ['style', 'javascript', 'stylesheet']; | ||
| const tags = ['style']; |
Contributor
Author
There was a problem hiding this comment.
that was wrong.
Liquid isn't rendered in {% javascript %} or {% stylesheet %} tags. Including Liquid code in these tags can cause syntax errors, or prevent styles from being applied to the theme.
charlespwd
force-pushed
the
fix-685-do-not-visit-schema-liquid
branch
from
684c07f to
f96d13f
Compare
karreiro
reviewed
Sep 24, 2025
Contributor
karreiro
left a comment
karreiro
left a comment
There was a problem hiding this comment.
Thank you, @charlespwd! I've left only two minor questions, please let me know your thoughts 🙏
charlespwd
force-pushed
the
fix-685-do-not-visit-schema-liquid
branch
from
f96d13f to
bbf2ba1
Compare
charlespwd
commented
Sep 24, 2025
| async LiquidVariableOutput(node) { | ||
| async LiquidVariableOutput(node, ancestors) { | ||
| // Do not report {{ foo == bar }} errors inside {% schema %} where they are supported | ||
| if (isWithinRawTagThatDoesNotParseItsContents(ancestors)) return; |
Contributor
Author
There was a problem hiding this comment.
That's a false positive, since we do support those
charlespwd
force-pushed
the
fix-685-do-not-visit-schema-liquid
branch
from
bbf2ba1 to
d7b7796
Compare
karreiro
approved these changes
Sep 24, 2025
Contributor
karreiro
left a comment
karreiro
left a comment
There was a problem hiding this comment.
Thank you, @charlespwd!
aswamy
approved these changes
Sep 24, 2025
We were visiting those nodes as though they were part of the execution
of the file when in fact those are not parsed by the backend but
stripped away.
I first tried doing that at the parsing layer by putting the body as a
TextNode (the same way `{% raw %}` does it) but quickly discovered that
we do depend on it being parsed for the StaticStylesheetAndJavascriptTags
check.
So instead, I just added a helper that both UndefinedObject and
UnusedAssign use to skip visiting of nodes that are parent'ed by a
"raw-like" tag
Fixes #685
charlespwd
force-pushed
the
fix-685-do-not-visit-schema-liquid
branch
from
d7b7796 to
294e604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
We were visiting those nodes as though they were part of the execution of the file when in fact those are not parsed by the backend but stripped away.
I first tried doing that at the parsing layer by putting the body as a TextNode (the same way
{% raw %}does it) but quickly discovered that we do depend on it being parsed for the StaticStylesheetAndJavascriptTags check.So instead, I just added a helper that both UndefinedObject and UnusedAssign use to skip visiting of nodes that are parent'ed by a "raw-like" tag
Fixes #685
Before you deploy
changeset