Upgrade Prettier to v3 #1118
Merged
Upgrade Prettier to v3 #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
charlespwd
force-pushed
the
cp-prettier-v3
branch
from
469b72c to
a2058e7
Compare
charlespwd
force-pushed
the
cp-prettier-v3
branch
from
a2058e7 to
8c981ca
Compare
graygilmore
approved these changes
Feb 3, 2026
Contributor
graygilmore
left a comment
graygilmore
left a comment
There was a problem hiding this comment.
Assuming that all of the code changes here are just formatting
Contributor
Author
|
yessir. It's mostly just prettier3 at the root + yarn format. I did have to deal with the prettier-plugin-liquid and how it supports prettier2 AND prettier3, but that stuff is stuffed in the webpack config changes. Basically we already imported prettier@2 as prettier2 in node_modules and prettier@# as prettier3. Most of the types in prettier-plugin-liquid were from prettier 2 so for the import to resolve correctly I had to change things there a little bit. Our entire test suite still passes + type-check + format:check. We're good :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Upgrade Prettier from v2.8.4 to v3.0.0. This update includes formatting changes across multiple files, primarily affecting interface declarations and conditional expressions. The changes are mostly related to line breaks and indentation.
Why?
Because ohm-js/wasm is making us newer features of ESM that prettier 2 doesn't support.
Before you deploy
changeset/asideClaude did the work but I did 🎩 and had it fix a couple of typing issues over a couple of loops.