Skip to content

Pin VS Code E2E tests to stable version#1122

Merged
charlespwd merged 2 commits intomainfrom
cp-vscode-e2e-pinning
Feb 6, 2026
Merged

Pin VS Code E2E tests to stable version#1122
charlespwd merged 2 commits intomainfrom
cp-vscode-e2e-pinning

Conversation

@charlespwd
Copy link
Contributor

@charlespwd charlespwd commented Feb 5, 2026

Summary

  • Add --quality=stable to vscode-test-web to use stable VS Code instead of Insiders
  • Add timeout-minutes: 15 to E2E job to fail fast on hangs

This addresses CI failures caused by VS Code Insiders changes that break the E2E tests.

Test plan

  • E2E tests pass locally with --quality=stable
  • CI passes with new config

🤖 Generated with Claude Code

charlespwd and others added 2 commits February 5, 2026 12:21
- Add --quality=stable to vscode-test-web to use stable VS Code instead of
  Insiders, which can break CI with untested changes
- Add timeout-minutes: 15 to E2E job to fail fast on hangs

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@charlespwd
Copy link
Contributor Author

Ran into issues where E2E tests failed because of insiders this morning. CI wasn't timing out. That's bad. This is about avoiding this kind of issue.

@charlespwd charlespwd marked this pull request as ready for review February 5, 2026 19:37
@charlespwd charlespwd requested a review from a team as a code owner February 5, 2026 19:37
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, @charlespwd!

@charlespwd charlespwd merged commit 85a319a into main Feb 6, 2026
8 checks passed
@charlespwd charlespwd deleted the cp-vscode-e2e-pinning branch February 6, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants