valid-schema-translations theme check

[aswamy]

What are you adding in this PR?

Part of #942

Added a new theme check called ValidSchemaTranslations that ensures all translation keys (t:) in schema have matching entries in the default schema translations file. This check supersedes the existing ValidSchemaName which only checked the schema.name value (along with a few more things).

The PR:

• Creates a new check that recursively finds all string values starting with 't:' in schema JSON
• Verifies each translation key has a corresponding entry in the translations file
• Reports error messages for missing translations
• Moves the translation existence check from ValidSchemaName to this new dedicated check

Tophat

Here is a schema you can test out the new theme-check (assuming you don't have t:general.headerfoo in your en.default.schema.json

{% schema %}
{
  "name": "t:general.headerfoo",
  "default": {
    "text": "t:general.headerfoo",
    "select": "option",
    "radio": "option",
  },
  "settings": [
    {
      "type": "text",
      "id": "text",
      "label": "t:general.headerfoo",
    },
    {
      "type": "select",
      "id": "select",
      "label": "t:general.headerfoo",
      "options": [
        {
          "group": "Select Group 1",
          "label": "t:general.headerfoo",
          "value": "option",
        },
        {
          "group": "Select Group 1",
          "label": "Option 2",
          "value": "option2",
        },
      ]
    },
    {
      "type": "radio",
      "id": "radio",
      "label": "Radio",
      "options": [
        {
          "label": "Option",
          "value": "option",
        }
      ],
    }
  ],
  "presets": [
    {
      "name": "Alok Section",
      "category": "t:general.headerfoo",
      "settings": {
        "text": "t:general.headerfoo",
        "select": "option",
        "radio": "option",
      }
    }
  ]
}
{% endschema %}

What's next? Any followup issues?

• Updating shopify-dev so that we have it documented

Before you deploy

• This PR includes a new checks or changes the configuration of a check
  • I included a minor bump changeset
  • It's in the allChecks array in src/checks/index.ts
  • I ran yarn build and committed the updated configuration files
  • I've made a PR to update the shopify.dev theme check docs if applicable.
    • I will do so after this PR since we aren't cutting a release for this theme-check yet

[aswamy]

• valid-schema-translations theme check #1123 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[charlespwd]

Beautiful 👌

[aswamy]

Merge activity

• Feb 5, 7:56 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Feb 5, 7:56 PM UTC: @aswamy merged this pull request with Graphite.