fix: use createRequire for node_modules resolution in VSCode extension#1171
Merged
aswamy merged 3 commits intoShopify:mainfrom Apr 17, 2026
Merged
Conversation
The VSCode extension server is bundled with webpack, which replaces
`require` with its own module system. webpack's `require.resolve` does
not support the `paths` option and returns a numeric module ID rather
than a file path, causing "Cannot find module" errors for custom check
packages (e.g. `@grafikr/theme-check-extension/recommended.yml`).
Replace `require.resolve(pathLike, { paths: getAncestorNodeModules(root) })`
with `createRequire` from `node:module`, which creates a real Node.js
require function that bypasses webpack's substitution. Node.js's native
module resolution already traverses ancestor node_modules directories
automatically, so `getAncestorNodeModules` is no longer needed.
Fixes Shopify#1170
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
I don't know how to test the VSCode extension. The build process seems to run in a loop for me |
aswamy
approved these changes
Apr 16, 2026
Contributor
aswamy
left a comment
aswamy
left a comment
There was a problem hiding this comment.
This is great stuff. I was able to use your theme-check in VSCode extension, and using the cli binary in theme-tools
aswamy
reviewed
Apr 16, 2026
andershagbard
commented
Apr 17, 2026
Contributor
|
Thanks a lot @andershagbard for the fix. Merging this PR now 🙏. It should be part of the next patch for VSCode Extension. I think we just had one recently so look out for the next PR that looks like it when you want to see it released. |
Contributor
Author
|
Thanks for quick review and merge 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@grafikr/theme-check-extension/recommended.yml) fromnode_modules, while the CLI works fine.requirewith its own module system. webpack'srequire.resolveignores thepathsoption and returns a numeric module ID instead of a real file path.createRequirefromnode:moduleto create a proper Node.js require function that bypasses webpack's substitution. Node.js's native resolution already traverses ancestornode_modulesdirectories, so thegetAncestorNodeModuleshelper is no longer needed.Test plan
read-yaml.spec.tstests pass (the node_module resolution test at line 105 exercises this exact code path)extendspackage in.theme-check.yml, verify no "Cannot find module" errorsCloses #1170
🤖 Generated with Claude Code