Skip to content

Update grammar to allow variables to be detected inside style tags#683

Closed
aswamy wants to merge 1 commit intomainfrom
bugfix/variable-not-used-false-positive
Closed

Update grammar to allow variables to be detected inside style tags#683
aswamy wants to merge 1 commit intomainfrom
bugfix/variable-not-used-false-positive

Conversation

@aswamy
Copy link
Copy Markdown
Contributor

@aswamy aswamy commented Jan 3, 2025

NOTE: DO NOT MERGE YET

  • After some testing, I found out that removing it from the raw tag section will format inside the style tag (changing a lot of files)

What are you adding in this PR?

Fixes #465

  • Style tag was being treated as a "raw" tag where liquid code isn't parsed inside it
    • Removed style tag from this list

Tophat

Before After
image image

Before you deploy

  • I included a patch bump changeset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False Positive "Variable Assigned but Not Used" in Style Tags

1 participant