Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
amomchilov
force-pushed
the
Alex/gem-infra
branch
4 times, most recently
from
97c8488 to
654d7ff
Compare
amomchilov
force-pushed
the
Alex/gem-infra
branch
from
654d7ff to
d29b4c1
Compare
KaanOzkan
approved these changes
Feb 20, 2026
amomchilov
force-pushed
the
Alex/gem-infra
branch
from
d29b4c1 to
783b606
Compare
amomchilov
force-pushed
the
Alex/gem-infra
branch
3 times, most recently
from
738e534 to
368b4ff
Compare
amomchilov
force-pushed
the
Alex/gem-infra
branch
from
368b4ff to
9bd8502
Compare
Morriar
reviewed
Feb 25, 2026
| continue-on-error: true | ||
| - name: Run tests | ||
| run: bundle exec rake test | ||
| continue-on-error: true |
Contributor
There was a problem hiding this comment.
Do we really want this to continue?
| @@ -1,3 +1,4 @@ | |||
| # typed: strong | |||
Contributor
There was a problem hiding this comment.
We advise against using strong, let's lead by example and use strict
| --ignore=tmp/ | ||
| --ignore=vendor/ | ||
| --enable-experimental-rbs-comments | ||
| --suppress-payload-superclass-redefinition-for=RDoc::Markup::Heading No newline at end of file |
Contributor
There was a problem hiding this comment.
Weird EOF, was this generated by Tapioca? We may need to fix something.
Contributor
Author
There was a problem hiding this comment.
No I think it was manual
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits for details. In short, setup Sorbet (static only) with RBS, Tapioca, Rubocop (with Shopify's styleguide), etc.