-
Notifications
You must be signed in to change notification settings - Fork 52
Add discount functions settings api docs #2534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
iphipps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Do you also need to generate the docs and pr on shopify-dev?
MitchLillie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Tom. You will need to add a changeset (yarn changeset, pick minor, commit the resulting file).
As Ian mentioned, after this is merged you will need to regenerate the docs and create a PR on shopify-dev
| @@ -0,0 +1,76 @@ | |||
| const supportedDefinitionTypes = [ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be a const? I feel it might be ideal to keep this as a type to avoid increasing the runtime size of the library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated and moved the SupportedDefinitionTypes to shared since they are used in Validation Settings as well.
cad2834 to
68510ff
Compare
@MitchLillie I added the changeset. |
5c9af98 to
1248670
Compare
Background
This PR adds a section for Discount Function Settings API, similar to the Validation Settings API.
Related PR: https://github.com/Shopify/web/pull/151973
Solution
Adding the interface and data provided to the extension point.
🎩
Spin Link
For info on how to setup docs: https://app-ui.docs.shopify.io/guides/documentation/ui-extensions
Checklist