Unstable release of checkout #2551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
jffortier
reviewed
Jan 6, 2025
packages/ui-extensions/src/surfaces/checkout/components/Badge/Badge.ts
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/checkout/components/Chat/AppBridge.ts
Outdated
Show resolved
Hide resolved
Contributor
rcaplanshopify
left a comment
rcaplanshopify
left a comment
There was a problem hiding this comment.
The changes look good, but I don't have high context on them. The changes related to localized fields were released to unstable in a separate patch.
jamesvidler
commented
Jan 6, 2025
Contributor
Author
jamesvidler
left a comment
jamesvidler
left a comment
There was a problem hiding this comment.
I'm confident all these changes should be included in the 2025-01 stable.
rcaplanshopify
approved these changes
Jan 6, 2025
jamesvidler
force-pushed
the
jkv/unstable-jan-6-2025
branch
from
eaebadd to
cae2ae9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Brings forward latest changes from the private checkout package. Some, if not all of these should be included in the 2025-01 stable release.
Checklist