-
Notifications
You must be signed in to change notification settings - Fork 53
Merge 2025-10 changes into 2026-01-rc #3734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ntent Update content on customer accounts polaris page
Fix all Polaris example validation issues (#2247)
### Background Part of shop/issues-checkout#8471 Related to Shopify/shopify-dev#64144 This PR adds documentation for using methods in Polaris Web Components within static pages of the customer account surface. ### Solution Added a new "Methods" section to the Polaris Web Components documentation that explains: - What methods are (functions for programmatic control) - When to use methods (for actions that can't be achieved through property changes alone) - Examples showing how to use methods like `hideOverlay()` with components like Modal The documentation includes code examples in both JSX and vanilla JavaScript formats, demonstrating how to create and control a modal using methods. ### 🎩 See Shopify/shopify-dev#64144 for details ### Checklist - [x] I have 🎩'd these changes - [ ] I have updated relevant documentation
Improved Table examples
### Background Part of shop/issues-checkout#8472 Part of shop/issues-checkout#8578 Part of shop/issues-checkout#8511 Part of shop/issues-checkout#8508 Part of shop/issues-checkout#8507 Part of shop/issues-checkout#8509 Part of shop/issues-checkout#8510 Part of shop/issues-checkout#8512 Related to Shopify/shopify-dev#63804 This PR improves the documentation for Customer Account UI Extension components by enhancing best practices sections with more detailed, actionable guidance. ### Solution Updated the best practices sections for multiple components to provide clearer, more specific guidance for developers. The changes include: - **Avatar**: Improved readability with better formatting and more concise language - **ButtonGroup**: Added a new best practices section with guidelines for grouping actions - **CustomerAccountAction**: Expanded guidance on information collection and form design - **ImageGroup**: Added recommendations for accessibility and visual spacing - **Menu**: Restructured content with clearer headings and more detailed organization principles - **Page**: Reorganized with clear subsections for headings, subheadings, and page-level actions - **Section**: Added a new best practices section with guidance on headings and actions These improvements make the documentation more actionable and help developers create more consistent, user-friendly interfaces. ### 🎩 See Shopify/shopify-dev#63804 for details ### Checklist - [x] I have 🎩'd these changes - [ ] I have updated relevant documentation
Fix validation examples and issues across admin components and patterns
…x-text-field-children-type Update admin ui extensions, fix TextField children, and add DropZone
Add patterns for Footer Help and Resource List. Change aria-labels for accessibilityLabel on button and clickable where applicable. Fix typo to Setup guide. Added comment to guide LLM to match image's aspect ratio to actual width and height.
Version Packages (2025-10)
…nsionComponents 20155: Add Box to BlockExtensionComponents
The 'changeset pre exit' command fails because the repo is not in pre-release mode (no .changeset/pre.json file exists). This command was incorrectly added and causes all /snapit requests to fail.
Points to Shopify/snapit@support-oidc-authentication to test OIDC support before merging the snapit PR. Related: Shopify/snapit#52 Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* IA for Target APIs linting Further revision * IA for components revert file change Revert file change
Added step to update npm to the latest version before creating a snapshot.
Add npm update step in deploy workflow
* Add admin.app.search.data extension target * Add changeset for admin.app.search.data target * Format changeset file with Prettier * Rename admin.app.search.data to admin.app.tools.data - Rename SearchDataApi to ToolsDataApi - Rename SearchDataOutput to ToolsDataOutput - Rename api/search-data directory to api/tools-data - Update extension target name * Rename SearchResult to ToolResult Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Change admin.app.tools.data to return undefined Remove ToolsDataOutput and ToolResult types as the extension target now returns undefined per issue requirements. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Use StandardApi for admin.app.tools.data target Remove custom ToolsDataApi in favor of StandardApi. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
npm@11.7 requires Node.js ^20.17.0 || >=22.9.0, but the project was using v20.10.0 which caused the deploy workflow to fail. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
stephenh-shopify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of files appear to have GIT merge related lines captured as code changes.
ex: "<<<<<<< HEAD", "=======
2025-10"
| ], | ||
| category: 'Target APIs', | ||
| subCategory: 'Standard APIs', | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and many lines below look like GIT -- should this be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having surface owners resolve those. They should all be gone now
andrewmcgov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Customer account changes look good 👍
packages/ui-extensions/docs/surfaces/point-of-sale/reference/apis/cart-line-item-api.doc.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah noticed the toast example still has duration in it. We probably didn't update that example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vctrchu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
POS ✅
Getting changes made to 2025-10 into 2026-01-rc before stable 2026-01 api release